Hi Jonathan, Jonathan Nieder wrote: > Ramkumar Ramachandra wrote: > >> This is a re-roll of rr/revert-cherry-pick, with Junio's suggestions >> ($gname/186365) implemented. > > Thanks for this. I am worried that some of my comments in previous > reviews (especially about change descriptions) were not addressed, > which could mean one of a few things: > > - you didn't notice them > - they were wrong > - you noticed them and they were describing real problems, but it > wasn't worth the time to fix them > > Fine. But I would like to know which case they fell into, so I can > learn in order to do a better job reviewing the future and know my > time is well spent. I suppose they were a combination of all three. I'm sorry- I'll try to be more careful and communicative in the future. Thanks for this round of reviews! -- Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html