On Mon, Dec 05, 2011 at 02:41:26PM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > More importantly, though, this seems to break t6300 badly. I haven't > > looked into why yet, though. > > Probably two issues. > > - opt.message (and the original 'message') was misnamed and confused the > patch author what "if (!message && !buf->len)" meant. > > - "opt" is a structure meant to be extensible, but is not initialized as > a whole, inviting future errors. Sorry for that and thanks for the investigation. > It still seems to be broken with respect to the primary thing the patch > wanted to do (t7400 "git tag -F commentsfile comments-annotated-tag" does > not seem to produce an expected result), so I'll kick it back to the > Kirill to look at. CLEANUP_ALL should always be default regardless of opt.message_given. I'll send new version. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html