On Mon, Dec 5, 2011 at 23:47, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> On Mon, Dec 5, 2011 at 21:07, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >>> Now, here are the biggies that we would want to try to have in reasonable >>> shape before the next release. >> >> I'd like to get the i18n series into 1.7.9 as well. I think it's ready >> as-is but some minor issues are sure to arise. > > Surely. > > My impression was that the part that can have interactions with the > existing codebase is already in, and it is just the matter of updating > what _() ans Q_() actually do, which can be reverted out quickly if it > turns out to be necessary, and that was why I didn't count it as part of > the "biggies" that make us worry. That's the gist of it. But it's still a massive 1300 line patch, which: * Calls setlocale(LC_MESSAGES) * Uses an evil trick to only call setlocale(LC_CTYPE) while loading message catalogs * Might have some portability problems on more obscure OS's. * Has some tests I've only tested on Linux, FreeBSD and Solaris So it might have some little surprises, and it would be nice to have it in master early on so we'll give it plenty of time to cook and discover any issues before 1.7.9. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html