On Mon, Dec 05, 2011 at 05:27:24PM -0500, Jeff King wrote: > I also looked at factoring out the "which cleanup mode to select" logic > from builtin/commit.c, but it turned out to just make things harder to > follow. While I was doing that, I also noticed this minor fix: -- >8 -- Subject: [PATCH] stripspace: fix outdated comment The comment on top of stripspace() claims that the buffer will no longer be NUL-terminated. However, this has not been the case at least since the move to using strbuf in 2007. Signed-off-by: Jeff King <peff@xxxxxxxx> --- builtin/stripspace.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/builtin/stripspace.c b/builtin/stripspace.c index 4d3b93f..1288ffc 100644 --- a/builtin/stripspace.c +++ b/builtin/stripspace.c @@ -22,8 +22,6 @@ static size_t cleanup(char *line, size_t len) * Remove empty lines from the beginning and end * and also trailing spaces from every line. * - * Note that the buffer will not be NUL-terminated. - * * Turn multiple consecutive empty lines between paragraphs * into just one empty line. * -- 1.7.8.rc4.4.g884ec -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html