In particular, we add gettext.sp to the target-specific rule which adds the GIT_LOCALE_PATH setting to EXTRA_CPPFLAGS, otherwise sparse complains thus: SP gettext.c gettext.c:125:25: error: undefined identifier 'GIT_LOCALE_PATH' Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> --- Hi Avar, If you are going to re-roll your latest i18n patch (commit 6c856c48, "i18n: add infrastructure for translating Git with gettext", 18-11-2011), could you please squash this patch into it. Thanks! ATB, Ramsay Jones Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index ac8c76d..f926b5f 100644 --- a/Makefile +++ b/Makefile @@ -2129,7 +2129,7 @@ config.sp config.s config.o: EXTRA_CPPFLAGS = \ attr.sp attr.s attr.o: EXTRA_CPPFLAGS = \ -DETC_GITATTRIBUTES='"$(ETC_GITATTRIBUTES_SQ)"' -gettext.s gettext.o: EXTRA_CPPFLAGS = \ +gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \ -DGIT_LOCALE_PATH='"$(localedir_SQ)"' http.sp http.s http.o: EXTRA_CPPFLAGS = \ -- 1.7.7 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html