Am 30.11.2011 04:20, schrieb Jeff King:
> On Wed, Nov 30, 2011 at 12:26:20AM +0100, René Scharfe wrote:
>
>>>>> +static int is_rfc3986_reserved(char ch)
>>>>> +{
>>>>> + switch (ch) {
>>>>> + case '!': case '*': case '\'': case '(': case ')': case ';':
>>>>> + case ':': case '@': case '&': case '=': case '+': case '$':
>>>>> + case ',': case '/': case '?': case '#': case '[': case ']':
>>>>> + return 1;
>>>>> + }
>> [...]
>> Sorry for my bikeshedding, but I'd paint it like this:
>>
>> return !!strchr("!*'();:@&=+$,/?#[]", ch);
>
> I was always under the impression that computed jumps via "switch" would
> out-perform even an optimized strchr. Of course, I never tested. And I
> doubt performance is even relevant here, and I admit I don't care overly
> much. I find them both equally readable.
>
> I'm going to leave it as-is unless somebody else wants to say "I
> strongly prefer version X".
Sure, the second one is significantly slower than the first one. I just
prefer it based one its looks in case performance doesn't matter, but
that's probably just me being (sometimes too) fond of terseness. :)
René
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html