On Tue, Nov 29, 2011 at 22:50, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> Jürgen Kreileder wrote:
>
>> a) To fix the comparison with the chopped string
>> b) To give the title attribute correct encoding
>>
>> Signed-off-by: Jürgen Kreileder <jk@xxxxxxxxxxxx>
>> ---
>> gitweb/gitweb.perl | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index 4f0c3bd..4237ea6 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -1695,11 +1695,11 @@ sub chop_and_escape_str {
>> my ($str) = @_;
>
> Why not simply
>
> my $str = to_utf8(shift);
>
Good question. Because I thought it broke something when I tested it.
I can't reproduce that now, though. Might have been something unrelated.
So:
-- >8 --
Subject: [PATCH] gitweb: Call to_utf8() on input string in
chop_and_escape_str()
a) To fix the comparison with the chopped string
b) To give the title attribute correct encoding
Signed-off-by: Jürgen Kreileder <jk@xxxxxxxxxxxx>
---
gitweb/gitweb.perl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index bfada0e..036ae46 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1699,6 +1699,7 @@ sub chop_and_escape_str {
my ($str) = @_;
my $chopped = chop_str(@_);
+ $str = to_utf8($str);
if ($chopped eq $str) {
return esc_html($chopped);
} else {
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html