On Sun, Nov 27, 2011 at 06:47:21AM -0800, Jakub Narebski wrote:
> David Ripton <dripton@xxxxxxxxxx> writes:
>
> > Remove the trailing 's' from "files", "insertions", and "deletions"
> > when there is only one of the item.
> >
> > Signed-off-by: David Ripton <dripton@xxxxxxxxxx>
> > ---
> [...]
> > - printf(" %d files changed, %d insertions(+), %d
> > deletions(-)\n", files, adds, dels);
>
> Whitespace damaged. Please turn off word wrapping (limiting line
> width) when sending patches.
>
> > + printf(" %d file%s changed, %d insertion%s(+), %d deletion%s(-)\n",
> > + files, (files == 1 ? "" : "s"),
> > + adds, (adds == 1 ? "" : "s"),
> > + dels, (dels == 1 ? "" : "s"));
> > }
>
> First, I think this is an API / plumbing and should not be changed.
> But I might be mistaken about that.
I think somebody already tried to do this not too long ago (don't know
if there as a patch) but the diffstat tool always uses the plural, and
it might break scripts.
cmn
Attachment:
signature.asc
Description: Digital signature