On Fri, 25 Nov 2011, Carlos Martín Nieto wrote:
This patch fixes this, but I think it would still break if the LF is
at the end of the file. Changing the `if (!input)` to put the LF in
the output buffer may or may not be the right soulution. I feel like
this should be handled by cascade_filter_fn rather than the actual
filter somehow, but Junio's comment (4ae66704 'stream filter: add "no
more input" to the filters') suggests otherwise.
I'm working on a cleaner patch that takes care of a bit of state, but
this is the general idea.
Looks good to me (and seems to work in my case).
Typo in the commit subject though.
cmn
--- 8< ---
Subject: [PATCH] convert: don't loop indefintely if at LF-to-CRLF streaming
^^^^^^^^^^^
This should be either "infinitely", or "indefinitely", but since we know
that the loop won't terminate "infinitely" is to be preferred.
Thanks,
--
Henrik Grubbström grubba@xxxxxxxxx
Roxen Internet Software AB