Re: [PATCH] make git-svn resilient to log.abbrevcommit = true

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Rast <trast@xxxxxxxxxxxxxxx> wrote:
> Shahid Alam wrote:
> > Add --no-abbrev-commit arg to working_head_Info()'s invocation
> > of git log.
> [...]
> > @@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {
> > sub working_head_info {
> > 	my ($head, $refs) = @_;
> > 	my @args = qw/log --no-color --no-decorate --first-parent
> > -	              --pretty=medium/;
> > +	              --no-abbrev-commit --pretty=medium/;
> 
> Undeniably a bug, but to prevent the same from happening again,
> wouldn't it be better to rewrite it using simply
> 
>   rev-list --first-parent --pretty=medium

Yes, I've never been happy with using "git log" for any internals since
it's a porcelain.  I'll gladly accept a tested patch which uses rev-list
instead.  Thanks!
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]