Adam Borowski <kilobyte@xxxxxxxxxx> writes: > The requirement to be in the toplevel directory when calling git-bisect is > pretty infuriating. I tried to find an explanation for this, and the only > reference I found was: > > http://thread.gmane.org/gmane.comp.version-control.git/27524/focus=27596 Interesting. It used to be that people were thankful when a command happened to work from a subdirectory, and it was a minor irritation when some command didn't; in the early days, everything in Git was to be used from the top-legvel. > However, since then, git-reset has been changed (in a81c311f). What about > changing git-bisect as well? > > A trivial patch seems to work for me, but I might have missed some corner > case. Thanks; read and follow Documentation/SubmittingPatches the next time perhaps? As to the approach, I suspect that it would be far better if it made workable with cd_to_toplevel at the beginning, instead of saying SUBDIRECTORY_OK. After all, the current directory may disappear during the course of bisection, upon checking out a revision that did not have the directory you started your bisection from. > > -- > 1KB // Yo momma uses IPv4! > > From 1dd5dda6a9db3d987e15784c4de24e593cc596e0 Mon Sep 17 00:00:00 2001 > From: Adam Borowski <kilobyte@xxxxxxxxxx> > Date: Wed, 23 Nov 2011 15:08:42 +0100 > Subject: [PATCH] git-bisect: allow using it from a subdirectory. > > Just like git-reset, restricting it to toplevel is an annoyance, and the > latter has been changed in a81c311f. > --- > git-bisect.sh | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/git-bisect.sh b/git-bisect.sh > index 99efbe8..fd6ccdd 100755 > --- a/git-bisect.sh > +++ b/git-bisect.sh > @@ -27,6 +27,7 @@ git bisect run <cmd>... > Please use "git help bisect" to get the full man page.' > > OPTIONS_SPEC= > +SUBDIRECTORY_OK=Yes > . git-sh-setup > . git-sh-i18n -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html