On Fri, Nov 18, 2011 at 02:27, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Subject: notes merge: eliminate OUTPUT macro > > The macro is variadic, which breaks support for pre-C99 compilers, > and it hides an "if", which can make code hard to understand on > first reading if some arguments have side-effects. > > The OUTPUT macro seems to have been inspired by the "output" function > from merge-recursive. But that function in merge-recursive exists to > indent output based on the level of recursion and there is no similar > justification for such a function in "notes merge". > > Noticed with 'make CC="gcc -std=c89 -pedantic"': > > notes-merge.c:24:22: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros] > > Encouraged-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Acked-by: Johan Herland <johan@xxxxxxxxxxx> -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html