On Tue, Nov 15, 2011 at 11:01:09PM +0100, Erik Faye-Lund wrote: > Yikes! Perhaps the whole deal of rewriting the code to take explicit > file descriptors (and/or dup-bonanza) would have been the better > choice after all? It's certainly simpler. This way is not that hard to fix; we just need to be more careful about the code path getting from upload-archive into write_archive. > For the record: I would be fine with c09cd77e simply being reverted > for this release, and having a better version applied in the near > future. Windows support for upload-archive is not worth the risk of > slipping in a remote code execution bug... I'd be OK with that, too. > Not only did you fail to spot them, you actually wrote that part of the code ;) > > http://article.gmane.org/gmane.comp.version-control.git/178098 > > (I don't mean to shift blame over to you, I'm the one who should have > spent more time thinking about this as this was "my" series) Heh. I did say "something like this" in that message, which is usually a sure sign I haven't actually thought too hard about the code I'm about to write. I'll be content to share the blame equally with you. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html