Hi Junio, Junio C Hamano writes: > [...] > With that observation, it would probably make more sense if "foo.c" > included the headers in the following order: > > - git-compat-util.h (or the prominent ones like "cache.h" that is known > to include it at the beginning); > - Anything the declarations in "foo.h" depends on; > - "foo.h" itself; and finally > - Other headers that "foo.c" implementation needs. > > That way, people who want to use "foo.h" can guess what needs to be > included before using "foo.h" a lot more easily. That's a good rule-of-thumb. Thanks :) -- Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html