> > test_expect_success \ > > + 'Firefox below v2.0 paths are properly quoted' ' > > + echo fake: http://example.com/foo >expect && > > + cat >"fake browser" <<-\EOF && > > + #!/bin/sh > > + > > + if [ "$1" == "-version" ]; then > > Using "==" is a bashism. Just use "=". Thanks (I have no skills enough in this area) > > Also, a style nit, but we usually spell this "test" and not "[". I > admit I don't care much, though. Oh, I see > > > + # Firefox (in contrast to w3m) is run in > > background (with &) > > + # so redirect output to "actual" > > + echo fake: "$@" > actual > > + fi > > + EOF > > + chmod +x "fake browser" && > > + git config browser.firefox.path "`pwd`/fake browser" && > > + git web--browse --browser=firefox \ > > + http://example.com/foo && > > + test_cmp expect actual > > Hmm. So we are running the fake browser in the background, but then > check that it has written something as soon as web--browse exits. > Isn't that a race condition? I.e., we could run "test_cmp" before the > browser has actually written anything? eeehh... you're right... but even on slow Windows Cygwin it is passed ) > I'm not sure there's a good way to do it. You would need either to > wait some pre-determined "it could not possibly take it longer than N > seconds to run" sleep, or we need some kind of synchronization point. > We can't wait call "wait" on the child PID (if we even have it, > because it's not our child). hmm... we can delete "actual" file and wait its appearance (with some timeout), no ? but I didn't see in tests anything like this > -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html