Junio C Hamano <gitster@xxxxxxxxx> wrote: > Umm, there is another place where $maxlines is used without > merit. Shouldn't we do something like below as well? ... > - generate_email $maxlines | send_mail > + generate_email | send_mail Agree. $maxlines is harmless, but extraneous here. Would you like me to reroll a patch with both or is this a trivial fixup? Cheng -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html