Re: bug: git-sh-setup should not be in $PATH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski escreveu:
>> there should be Makefiles in said directories. Otherwise, every rule
>> in the toplevel Makefile saying
>>
>>
>>   $(MAKE) -C subdir/
>>
>> will fail because $builddir/ does not have a Makefile in
>> $builddir/subdir.
> 
> Wouldn't it be better just to modify toplevel Makefile to say:
> 
>    $(MAKE) -C $(srcdir)/subdir/
> 
> without messing with ./configure script, and creating "redirect"
> Makefiles?
> 

that doesn't work.

  make -C foo bla

just does 

  (cd foo && make bla)

If you did this, part of the object files would end up in the source dir; 
The idea of separate srcdir builds,is to keep the srcdir completely clean 
of generated files.  That can't really be done without aid of a script,
to setup the builddir. In this case that is the configure script.

I did forget to add a check 

  if "$srcdir" != "." ; then
    ..
  fi

around the messy stuff.



-- 
 Han-Wen Nienhuys - hanwen@xxxxxxxxx - http://www.xs4all.nl/~hanwen
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]