Re: [PATCH v2 00/12] Pulling signed/annotated tags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:

> On Mon, Nov 7, 2011 at 7:00 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> This is a re-roll of the fourth iteration.
>
> Ok, this all looks fine to me.
>
> Clean series, and everything looks fine.
>
> The one thing I wondered about is what happens when you merge two
> signed tags. Maybe I read the patch wrong, but it *looks* to me like
> the code just appends them all together with nothing in between. Is it
> still parseable?

Eek.

The mergetag stuff is a dump of "cat-file tag" so if you have a line that
begins with "object " the parsing side (which does not exist yet) would
have trouble. We would need to devise e.g. adding number of lines at the
beginning, or something.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]