On 07.11.2011 17:47, Junio C Hamano wrote:
2564aa4 started to initialize buf.alloc, but that should actually be one
more byte than the string length due to the trailing \0.
Even when the conversion result is a zero-length string?
In this case, yes. The string buffer is initialized (and detached) in
run_textconv, which calls strbuf_read, which grows the (yet empty)
string to 8192 bytes. So alloc is always > 0, and the detach will trim
alloc to len + 1.
However, Peff made another valid point and I'll send v2 soon.
--
Sebastian Schuberth
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html