On Mon, Nov 07, 2011 at 09:02:23AM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > I should probably polish and submit the patch here: > > > > http://thread.gmane.org/gmane.comp.version-control.git/182238/focus=182475 > > I was actually hoping that you won't go that route, but the route to push > further to decide/spawn pager as late as possible. Clearly no sane person > would want to run --edit subcommand under pager and "pager.config = less" > should just be ignored in such a case. The problem with that is that it dumps the responsibility for running the pager to every subcommand. For builtins, we can have a flag that says "respect the pager.log config" or "foo will handle this itself; don't respect pager.tag". But what about externals? If "pager.stash" does nothing in git.c, and leaves it to "git-stash.sh" to start the pager if and when it's appropriate, then what about my personal "git-foo" that I drop into my PATH? Now I can't use "config.foo" without carrying code to do so in my external command. Maybe that's an OK tradeoff. But it's more of a pain for existing scripts, and it's not backwards compatible. What do you think? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html