Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Remove an "p->field < 0" comparison in grep.c that'll always be > false. In this case "p" is a "grep_pat" where "field" is defined as: > > enum grep_header_field field; > > And grep_header_field is in turn defined as: > > enum grep_header_field { > GREP_HEADER_AUTHOR = 0, > GREP_HEADER_COMMITTER > }; > > Meaning that this comparison will always be false. The underlying integer type is implementation-defined, and can be any signed or unsigned integer type that can represent all enumerations. Andreas. -- Andreas Schwab, schwab@xxxxxxxxxxxxxx GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html