Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > Pathspec in "git log -p <pathspec>" is used for both commit pruning > and diff generation. If --full-diff is given, then diff pathspec is > reset to generate complete diff. > > This patch gives more control to diff generation. The first pathspec in > "git log -p -- <pathspec> -- <pathspec>" is used as commit pruning > as usual. The second one is used for diff generation. So --full-diff > now is essentially "git log -p -- <pathspec> --". I agree that giving more control to diff generation is a good idea, and this certainly is better than the previous round that nobody reviewed before you rerolled this round. But I have doubts about declaring "--full-diff is equivalent to giving the 'output' pathspec that is empty". Have you thought about the interaction between this and -M/-C options? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html