On Fri, Nov 4, 2011 at 5:48 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Naewe <stefan.naewe@xxxxxxxxx> writes: > >> http-push prompts for a password when the URL is set as >> 'https://user@host/repo' even though there is one set >> in ~/.netrc. Pressing ENTER at the password prompt succeeds >> then, but is a annoying and makes it almost useless >> in a shell script, e.g. >> >> Signed-off-by: Stefan Naewe <stefan.naewe@xxxxxxxxx> >> --- > > Thanks. > > With this the only callsite of init_curl_http_auth() becomes the one after > we get the 401 response, and this caller makes sure that user_name is not > NULL. > > Do we still want "if (user_name)" inside init_curl_http_auth()? Dunno... I think what Peff says makes sense. > I tried to rewrite the proposed commit log message to describe the real > issue, and here is what I came up with: > > [...] Looks good to me. > What is somewhat troubling is that after analyzing the root cause of the > issue, I am wondering if a more correct fix is to remove the user@ part > from the URL (in other words, document that a URL with an embedded > username will ask for password upfront, and tell the users that if they > have netrc entries or if they are accessing a resource that does not > require authentication, they should omit the username from the URL). Don't get me wrong, but I really don't care. I just wanted to have that issue fixed, to get my scripted 'multi repository pull' working again. Regards, Stefan -- ---------------------------------------------------------------- python -c "print '73746566616e2e6e6165776540676d61696c2e636f6d'.decode('hex')" -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html