On Thu, Nov 03, 2011 at 01:56:13PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > So you would agree that we are better summing the objects for all packs > > and showing one big progress bar? > > If it can be done without sacrificing the clarity of the code, compared to > the "we will do new and smaller ones first so in practice it does not > matter" approach taken by the patch in question, I would not mind it, but > to be honest, I do not deeply care either way. I looked briefly at doing this. It's a little annoying with the verify_packs code, because you have to pass around the "how far are we into the progress" counter separately. But I confess I don't care that much either way, either. With the two minor fixups I sent in my original review, I think Duy's patch would be OK by me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html