On Tue, Nov 1, 2011 at 5:45 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Erik Faye-Lund <kusmabite@xxxxxxxxx> writes: > >> This is a slip-up in my patch 0f77dea, but I don't quite understand >> why this didn't cause any troubles until now... I guess the MSVC parts >> of Makefile are somehow more dependent on LIB_H or something... >> >> Junio, is it too late to squash in a fix-up? If it is, I can send a >> fixup-patch instead... > > I can queue this for v1.7.8-rc1 if you want, as it is a fix whether or not > we define MSVC or not while building. Yes, please do. This looks good to me, thanks for picking it up :) >> So there's some more work left to be done. Unfortunately, I don't have >> time to polish these changes for at least a week, so unless someone >> volunteers it'll take some time... > > It seems, from your description, that msvc update series has some way to > go and it probably is better to be cooked by Windows-savvy folks for > another cycle. I don't think you need to hold these three patches; with them I was able to build your 'master'. I believe the problems I bumped into only exist in msysgit's 'devel' (or in your 'next', which msysgit/devel is based upon). > Which would mean that your upload-archive series is still > good to go as long as it works for non-MSVC/mingw people, right? > Yes. Apart from the slip-up with LIB_H, my upload-archive series should be unrelated to the issues I found here. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html