On Tue, Nov 01, 2011 at 11:12:49AM -0700, Junio C Hamano wrote: > Stefan Näwe <stefan.naewe@xxxxxxxxxxxxxxxxxxxx> writes: > > >>> * HTTP transport did not use pushurl correctly, and also did not tell > >>> what host it is trying to authenticate with when asking for > >>> credentials. > >>> (merge deba493 jk/http-auth later to maint). > >> > >> This seems to break pushing with https for me. > >> It never uses values from my '~/.netrc'. > >> I'll come up with a detailed scenario later. > > > > Update: > > > > git push prompts for the password but just pressing return succeeds. > > > > Weird... > > There are only handful of commits that even remotely touch http related > codepath between v1.7.7 and v1.7.8-rc0: > > * deba493 http_init: accept separate URL parameter > > This could change the URL string given to http_auth_init(). > > * 070b4dd http: use hostname in credential description > > This only changes the prompt string; as far as I understand it, the > condition the password is prompted in the callsites of git_getpass() > has not changed. > > * 6cdf022 remote-curl: Fix warning after HTTP failure > * be22d92 http: avoid empty error messages for some curl errors > * 8abc508 http: remove extra newline in error message > * 8d677ed http: retry authentication failures for all http requests > * 28d0c10 remote-curl: don't retry auth failures with dumb protocol > > These shouldn't affect anything wrt prompting, unless you are somehow > internally reauthenticating. > > Could you try reverting deba493 and retest, and then if the behaviour is > the same "need ENTER", further revert 070b4dd and retest? I don't use .netrc, but with all of my patches (most of which aren't even in what you are running), I tried not to affect the netrc case. I just checked a few things, and it seems to be working as I expect. Do we have a repeatable test? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html