On Mon, Oct 31, 2011 at 9:34 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Thanks. The patch looks good from a POSIX person's point of view, and I do > not immediately see how this would break other variants of Windows build > at least from the code inspection. > > So I'll queue this, but I'll leave it to you and msysgit folks to decide > if this topic should be merged to 1.7.8-rc1, as I do not have equipment, > expertise, nor time to judge it myself (other than the code inspection we > have already done here). > > Please give me an Ack or two by the end of this week. Thanks. The result of applying this on top of the current master (1.7.8-rc0) compiles and seem to runs fine for me, both with the MinGW supplied by msysGit, and MSVC (as outlined by compat/vcbuild/README). Without the patches, it fails to build with MSVC. In addition, the changes looks good to me. So: Acked-by: Erik Faye-Lund <kusmabite@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html