On Thu, 27 Oct 2011 13:27:54 +0300 Jonas Berlin <xkr47@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 27 Oct 2011 11:05:30 +0200 > SZEDER Gábor <szeder@xxxxxxxxxx> wrote: > > The $output variable is not declared as local and therefore it leaks > > into the environment. But instead of declaring it local, why not > > eliminate it altogether, and use the "$(git config ....)" command > > substitution as here string? > > Wouldn't this work: > > git config -z --get-regexp '^(svn-remote\..*\.url|bash\.showupstream)$' 2>/dev/null | tr '\0\n' '\n ' | \ > while read key value; do > ... > done Sorry, please disregard, I didn't notice it was already dismissed in v1 of the PATCH.. - xkr47 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html