On Sat, Oct 22, 2011 at 09:04:19PM +1100, Nguyen Thai Ngoc Duy wrote: > This series helps pass commit message size up to output functions, > though it does not change any output functions to print ^@. Can we take a step back for a second and discuss what git _should_ do with commits that contain NUL? If all of the pretty-print functions are just going consider "foo\0bar" to be "foo^@bar", then maybe it would be much simpler to just "normalize" the commit message into a C string at a lower level, and pass it around as a string as we currently do. On the other hand, if we are eventually looking to add an option like "--include-NUL-in-commit-message", then it would make sense for the real contents and size to get passed around. > All functions up to the last patch learn to accept a string as a pair > <const char *start, const char *end> as a preparation step. These > changes are relatively simple. Or it could have been so if I did not > attempt to reduce some code duplication found while working on this > series. Great. Reducing code duplication is always a plus. > The last patch turns commit_buffer field in struct commit to "struct > strbuf *". This approach costs us 12 bytes more each commit. We can > choose not to use strbuf to save memory. I think 12 bytes in the commit struct might be noticeable. But it looks like you've done the sane thing, and replaced the pointer-to-char with a pointer-to-strbuf. And that I don't think should be a big deal. The buffer itself is way bigger than 12 bytes, so we don't care so much about the "we have a buffer" case, but more about the 100,000 other commits that we're not currently printing right now. Of course, some timings on things like "rev-list" and "pack-objects" would be nice to double-check. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html