On Tue, Dec 05, 2006 at 05:30:56PM +0000, Catalin Marinas wrote: > On 30/11/06, Yann Dirson <ydirson@xxxxxxxxxx> wrote: > >+- numeric shortcuts for naming patches near top (eg. +1, -2) > > We currently have the -n option for push and pop that accepts number. > Because of python, you can also, for example, push to the last but one > with "push -n -1" (similar for pop). Do you mean shortcuts for the > "goto" command? I rather meant shortcuts for "show", "fold --pick", and possibly a handful of others. While we're talking about shortcuts for goto, one that I regularly miss would be something like "goto BACK", to allow for short excursions and quickly going back without having to worry on which exact patch I was before. "refresh --patch" will make this less essential, but still possibly useful. > >+- refuse to "stg init" a branch known as remote (through .git/remotes/, > >+ .git/branches/ or any other info) > > I think it is up to the user not to do this. It may not be obvious to a new user, so I'd think it would be useful to guard against things we know should not be done. "git checkout" being probably used as plumbing in several places should probably not be taught to refuse switching to remote branches, so I'd think porcelains should take care of this. > You would first need to check out such a branch anyway. Sure. Especially, the following should probably fail :) |stgit$ stg branch origin |Switching to branch "origin"... done Maybe it could be made to accept only to change to stgit-managed branches ? After all, if we're switching to a non-stgit branch, we're probably going to use another set of tools anyway, so we can probably tell the user to use git-checkout or cg-switch instead. > >+- cannot use "stg refresh file" after "cg-rm file" > > It seems to work for me. Can you send some log messages? I should have done that first, I cannot reproduce it any more. > >+- "stg goto $(stg top)" fails with unhandled exception > > It works for me. What StGIT version do you use? I got that error on 0.11 - and just checked that 9b63cf56576bf219d26f490f3c011e937a5f7129 fixes exactly this problem already. Sorry, I should have checked on master first. > >+- at least "commit is not robust wrt out-of-diskspace condition: > >+|deps$ stg commit > >+|error: git-checkout-index: unable to write file MANIFEST > >+|error: git-checkout-index: unable to write file META.yml > >+|error: git-checkout-index: unable to write file Makefile.PL > >+|error: git-checkout-index: unable to write file doc/README.dbk.xml > >+|error: git-checkout-index: unable to write file graph-includes > >+|error: git-checkout-index: unable to write file > >lib/graphincludes/params.pm > >+|fatal: unable to write new index file > >+|stg commit: git-read-tree failed (local changes maybe?) > >+|Committing 4 patches... > >+(luckily nothing was really committed) > > But that's the correct behaviour, not to commit anything. Right. > StGIT cannot know > how much space is needed by GIT to check this beforehand. It simply > exits when a GIT command failed. What I had in mind, is that when something fails midway, if we just exit we may end up in an inconsistent state. I have not taken the time to check about that, that's why I wanted it to appear in the TODO file. Again, it was quite poorly worded, to say the least. Best regards, -- Yann. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html