Re: [PATCH] gitweb: provide a way to customize html headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lénaïc Huard <lenaic@xxxxxxxxxxxxxxxx> writes:

> +GITWEB_SITE_HTMLHEADER =
>  GITWEB_SITE_HEADER =
>  GITWEB_SITE_FOOTER =

Is it just me or does the inconsistency between the existing two variables
and this new one with a very similar name stand out like a sore something?

It might have been better if GITWEB_SITE_(HEADER|FOOTER) were named with
"_FILE" suffix, but as long as we consider/declare insert_file is the norm
and in-place inclusion of mini-string is an oddball, it is sufficient to
call this GITWEB_SITE_HTML_HEAD_STRING to avoid confusion?

Perhaps GITWEB_SITE_HEADER_STRING and GITWEB_SITE_FOOTER_STRING might turn
out to be useful in the future for in-place inclusion of mini-strings, and
when that happens, you two would thank me for this suggestion ;-)

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]