Hi, On Tue, 5 Dec 2006, Jakub Narebski wrote: > Johannes Schindelin wrote: > > > On Mon, 4 Dec 2006, Linus Torvalds wrote: > > > >> [core] > >> escapefilenames = true > > > > I think this goes too far. The problem _only_ showed up with a made-up > > test case for gitweb. Let's bite the apple when we _have_ to (which I > > doubt will happen, because for the most part, developers understand that > > spaces and umlauts have _no_ place in filenames, basically since UNIX was > > invented by stupid US Americans who did not know anything about nice > > filenames, let alone other languages than English and C). > > No, the problem showed with stupid HFS+ which uses different encoding > for creating file, and different for readdir. This is just one of the problems. I described another problem in this thread, namely a repo on a usb stick being accessed from different hosts. > Perhaps we should remove gitweb/test directory, and move testing gitweb > to proper place, t/ directory. If you do that, please make sure that these tests can be disabled (a la svn tests), so that people not being interested in gitweb, or lacking the programs to test it, do not have to suffer. > By the way, would it be correct to use external tools (if they exist), > namely HTMLtidy in gitweb output test to-be-written? (Yes, they exist. HTMLtidy for example ;-) IMHO if such a tool is common enough, you should use it. If anybody steps forward providing automated HTTP tests, I will not complain, and certainly not about testing with things like HTMLtidy. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html