On Oct 15, 2011, at 11:36 PM, Junio C Hamano wrote: > Matthew Daley <mattjd@xxxxxxxxx> writes: > >> git-send-email sends two SMTP EHLOs when using TLS encryption, however >> only the first, unencrypted EHLO uses the SMTP domain that can be >> optionally specified by the user (--smtp-domain). This is because the >> call to hello() that produces the second, encrypted EHLO does not pass >> the SMTP domain as an argument, and hence a default of >> 'localhost.localdomain' is used instead. >> >> Fix by passing in the SMTP domain in this call. >> >> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx> > > Sounds sensible, thanks. > > Brian, who did 69cf7bf (send-email: Cleanup smtp-domain and add config, > 2010-04-10) to make the initial hello use $smtp_domain, could you take a > quick look and an Ack? It does look sensible to me, but I wasn't the one who added all the HELO work. I mostly was mucking about with variable names and how they got set. Jari Aalto added them originally in 134550f. ~~ Brian-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html