René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > For some reason $LOGNAME is not set anymore for me after an upgrade from > Ubuntu 11.04 to 11.10. Use $USER in such a case. > > Signed-off-by: Rene Scharfe <rene.scharfe@xxxxxxxxxxxxxx> > --- > The only other use of $LOGNAME is in git-cvsimport, which does the same. While the change to assign $USER to $LOGNAME when the latter is not set is not wrong per-se, I have to wonder (1) why this test should use LOGNAME not USER in the first place, and (2) why you lost LOGNAME. LOGNAME The system shall initialize this variable at the time of login to be the user's login name. See <pwd.h> . For a value of LOGNAME to be portable across implementations of POSIX.1-2008, the value should be composed of characters from the portable filename character set. Will apply anyway. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html