On Thu, Oct 13, 2011 at 6:35 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Move most of the code from read_bundle_header() to parse_bundle_header() > that takes a file descriptor that is already opened for reading, and make > the former responsible only for opening the file and noticing errors. ... > * It generally is a bad practice to base a non-RFC patch on an RFC one, > but in any case here is how I would do the is_bundle() helper. I didn't label it RFC, but I did pose a question in the message section. Is there a rule for what marks something as RFC (if not the RFC label in the subject line)? Your implementation looks fine to me. Phil -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html