Re: [PATCH 2/9] completion: optimize refs completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 08, 2011 at 04:54:36PM +0200, SZEDER Gábor wrote:
> So, add a specialized variant of __gitcomp() that only deals with
> possible completion words separated by a newline 

> @@ -2635,7 +2659,7 @@ _git ()
>  			"
>  			;;
>  		*)     __git_compute_porcelain_commands
> -		       __gitcomp "$__git_porcelain_commands $(__git_aliases)" ;;
> +		       __gitcomp_nl "$__git_porcelain_commands $(__git_aliases)" ;;
>  		esac
>  		return
>  	fi

Oops, this last hunk is wrong.

I made the thinko that $__git_porcelain_commands is NL-separated and
the output of __git_aliases() is NL-separated, so we can pass the two
together to the new __gitcomp_nl() function.  But of course not,
because the SP between the two joins the last command and the first
alias.

I will resend in the evening with this hunk removed and the commit
message updated.


Gábor

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]