Jeff King venit, vidit, dixit 13.10.2011 00:46: > On Wed, Oct 12, 2011 at 03:38:27PM -0700, Junio C Hamano wrote: > >> Jeff King <peff@xxxxxxxx> writes: >> >>> On Wed, Oct 12, 2011 at 05:43:16PM -0400, Jeff King wrote: >>> ... >>>> Instead, let's just add a separate URL parameter to >>>> http_init, and all three callsites can pass in the >>>> appropriate information. >>>> >>>> Signed-off-by: Jeff King <peff@xxxxxxxx> >>> >>> Sorry, I forgot to mention: this is meant to go on top of the >>> http-auth-keyring topic. >> >> Hmm, of course the patch was written to help http-auth-keyring topic, but >> wouldn't this be an improvement that is general enough? I.e. it could >> even go to the bottom of the topic, no? > > Yes, it could, and probably should. I suspect it might need some > rebasing to do that. > > I'm going to float some other possible designs for the topic as soon as > I put enough polish on them. So I'll try to move this down when I > re-roll. In the meantime, if you want to throw it on top, great. If you > want to ignore it until then, no problem. :) > > -Peff Thanks, Jeff. To clarify: Without http-auth-keyring, this helps in the sense that git reads the username from a user@host URL and asks for the password only. When using GIT_ASKPASS or such, the askpass helper is called with "Password:" only. With (parts of) http-auth-keyring, the askpass helper is called with "Password for:user@host", which helps the user identify the request, and which helps helpers such as ksshaskpass to store the password with a meaningful key in a wallet. I'm not sure whether it's feasible/worth taking these bits of http-auth-keyring (improved prompt) out and apply them early. That is, I'm sure it's worth it (it would alleviate the need for credential helpers for some users at least), I haven't looked at feasibility ;) Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html