Re: [PATCH 1/3] t5403.1: simplify commit creation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/10/13 Johannes Sixt <j.sixt@xxxxxxxxxxxxx>:
> Am 10/12/2011 11:35, schrieb Nguyễn Thái Ngọc Duy:
>>  test_expect_success setup '
>>       echo Data for commit0. >a &&
>>       echo Data for commit0. >b &&
>> -     git update-index --add a &&
>> -     git update-index --add b &&
>> -     tree0=$(git write-tree) &&
>> -     commit0=$(echo setup | git commit-tree $tree0) &&
>> -     git update-ref refs/heads/master $commit0 &&
>> +     git add a b &&
>> +     git commit -m setup &&
>>       git clone ./. clone1 &&
>>       git clone ./. clone2 &&
>>       GIT_DIR=clone2/.git git branch new2 &&
>
> I don't think this change is necessary. It doesn't hurt to use plumbing
> commands here and there in the test suite to exercise them to a degree
> that they deserve.

I'm fine either way, for the record.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]