On Wed, Oct 12, 2011 at 01:46:43PM -0400, Jeff King wrote: > On Wed, Oct 12, 2011 at 12:29:39PM -0400, Jeff King wrote: > > > The explanation matches what we do now, but it did end up a bit longer > > than I had hoped. We could make it a lot shorter by: > > > > 1. Canonicalizing the section and key names that the caller gives to > > git-config. > > Hmm. Scratch that. We seem to do this already in my tests. I'll look > further and try to make a better documentation patch. OK, I was all set to do a patch to git-config for this, but it seems the code is already there. It's only the subsections which are the sticking point, and those can't be canonicalized, because in most cases we need to match them exactly. In the process, I did some cleanup and added some new tests to t1300, which I think are probably worth applying anyway. [1/2]: t1300: put git invocations inside test function [2/2]: t1300: test mixed-case variable retrieval -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html