Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > I'm still struggling with read_directory() rewrite so that struct > pathspec can be used throughout git, but now realized we can at least > enable magic for certain commands and die() on those that don't. > This may help move magic pathspec patches forward. I actually was thinking that teaching those that take bare "const char **" to take "struct pathspec *" is much more important conversion before adding more magic to those that already do take "struct pathspec *". The ones that ask "does this path match the pathspec" would automatically start honoring negative or quantum or whatever magic once we teach the magic to match_pathspec(), but the ones that take "const char **" will have no way of doing so before getting converted to "struct pathspec *" interface. If some parts of the system knows more magic and people start playing with them, the lack of the support in codepaths that haven't been converted will become real pain point. That is not to say that these 6 patch series are wasted patches. I just think it may be doing things in a wrong order. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html