Re: [PATCH] git-difftool: allow skipping file by typing 'n' at prompt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 11, 2011 at 2:26 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:

> I also wondered if this is easier to read:
>
>        pipe | stdin_contains m2 &&
>        ! pipe | stdin_contains master

> but I do not think it is (we cannot say "pipe | ! stdin_contains master").

Agreed on both counts.

"pipe | ( ! grep master )" does work, but I suspect that is an
inconsistency in the shell so I didn't want to use it.  IIRC the "(
list )" constrict is not supposed to make *that* much difference.
Have to check when I have time.

> In any case, here is what I ended up queuing.  Thanks.

> +stdin_doesnot_contain()
> +{
> +       ! stdin_contains "$1"
>  }

(facepalm) Why didn't I think of that!

Thanks :-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]