Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > The previous logic in show_config was to print the delimiter when the > value was set, but Boolean variables have an implicit value "true" when > they appear with no value in the config file. As a result, we got: > > git_Config --get-regexp '.*\.Boolean' #1. Ok: example.boolean > git_Config --bool --get-regexp '.*\.Boolean' #2. NO: example.booleantrue > > Fix this by defering the display of the separator until after the value > to display has been computed. > > Reported-by: Brian Foster <brian.foster@xxxxxxxxxxxx> > Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx> > --- Thanks. Will queue for maintenance track. > diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh > index 3e140c1..dffccf8 100755 > --- a/t/t1300-repo-config.sh > +++ b/t/t1300-repo-config.sh > @@ -333,6 +333,12 @@ test_expect_success 'get-regexp variable with no value' \ > 'git config --get-regexp novalue > output && > cmp output expect' > > +echo 'novalue.variable true' > expect > + > +test_expect_success 'get-regexp --bool variable with no value' \ > + 'git config --bool --get-regexp novalue > output && > + cmp output expect' > + > echo 'emptyvalue.variable ' > expect > > test_expect_success 'get-regexp variable with empty value' \ This matches the style of the surrounding code, but we may want to update this to a more modern style. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html