On Fri, Oct 07, 2011 at 06:37:13PM +0200, Carlos Martín Nieto wrote: > > I assume you mean s/tag/branch/ in the last line? > > Yeah, maybe ref would be better? Yeah, agreed. > > Tests? > > Good point. It sounds like you already have a reproduction recipe for this, and for the --tags thing in the next commit. > OK, so take a step back and figure out what we want the rules to be > before we call get_stale_heads. It does sound like a more elegant > approach. I was trying to disrupt the callers as little as possible, but > then again, there's only two. Will change. Yeah. Sometimes we try hard to make a minimal patch, because it makes it easier to review. At the same time, I think it's more important to make the code clean if it needs it. Especially when there aren't many callers to disrupt. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html