Junio C Hamano <junkio@xxxxxxx> wrote:
> Thanks.
>
> Please CC people who are primarily working on the part of the
> system you are improving. In the case of git-svn that would be
> Eric Wong.
Yes, CCs regarding git-svn would be much appreciated, thanks.
> As I almost never touch git-svn myself, I'll queue these four
> changes in 'pu' while waiting Ack from Eric on them.
Ack on what the patches do, but not as-is.
Please fix the coding style so that it's consistent with the rest of
git-svn:
a) indentation is done with hard tabs
b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {"
Also, adding tests would be helpful in helping me maintain it (I'm not
a regular svk user, so I don't want to break anything you've done down
the line).
Thanks.
--
Eric Wong
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html