Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > --- > Note that if a service fails, then "access denied" is printed too. After run_service() returns with a failure, it is simply irresponsible to append an "ERR" packet to the output channel without knowing what the state of that channel is (e.g. it might be that the service wrote only half a pkt_line it wanted to write, and you may be appending to it). I think the earlier patch from Peff makes the division of responsibility clearer. If the daemon's dispatch code notices it does not want to run it, it is the daemon's job to report it. Otherwise the service can and should report what it does, and after it starts running, the channel belongs to the service. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html