On Fri, Sep 30, 2011 at 11:13:25AM -0700, Junio C Hamano wrote:
> I wonder if something along the following line would make the usage more
> pleasant and self-explanatory:
>
> $ git bisect start --used-to='git frotz says xyzzy' v0.99 master
> Bisecting: 171 revisions left to test after this (roughly 8 steps)
> $ ... build and then test ...
> $ git bisect tested
> You are trying to check: git frotz says xyzzy
> Does the result satisify what you are trying to find [y/n]? yes
I like this idea a lot. My "yes/no" thing was a "if I were designing
bisect from scratch today..." suggestion, but having something like
--used-to makes it a natural addition to the regular good/bad interface.
And I really like the prompt to help people remember what it is they're
declaring each time.
However, --used-to feels a bit backwards to me. I think of it as
"--has-property" or something similar. That is, you are looking for when
something appeared (be it a bug, a feature, or whatever). But I guess it
depends on what you are bisecting. In my case, "yes" would be the
current "bad", and "no" would be the current "good".
So maybe provide both --used-to and --has-property (which I really
dislike as a name, but I can't think of anything better at the moment).
And then we can interpret "yes" and "no" accordingly, depending which
one the user used (and while that _sounds_ confusing, it won't be to the
user; we'll be prompting them with "you're looking for ...", so their
answer will be very natural).
But with both of them, the user is free to phrase it in whatever way
feels natural.
> When trying to find regression, you would say:
>
> $ git bisect start --used-to='it works' v0.99 master
Just for completeness, under my proposal this could also be:
$ git bisect start --has-property='git frotz is broken' v0.99 master
Which is probably slightly less natural. But:
> When trying to find a fix, you would say:
>
> $ git bisect start --used-to='checkout $tree $path clobbers $path' v0.99 master
This one would be a bit nicer:
$ git bisect start --has-property='checkout works' v0.99 master
-Peff
PS Side note: do we really need it to be interactive? I would think
you could do:
$ git bisect start --used-to='git frotz says xyzzy'
Bisecting: 171 revisions left to test after this (roughly 8 steps)
Checking whether 'git frotz says xyzzy'.
$ ... build and test ...
$ git bisect yes
Bisecting: 89 revisions left to test after this (roughly 7 steps)
Checking whether 'git frotz says xyzzy'.
It means the user is reminded, then tests, then responds. But I think
it would be enough of a reminder. The important thing is that we keep
mentioning it at each bisection step. Maybe it depends on how long
your build/test step is (I tend to work on things like git, where
that is a 30-second procedure, not a kernel with a long build and a
reboot in between :) ).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html