Jakub Narebski <jnareb@xxxxxxxxx> writes: > On Fri, 30 Sep 2011, Junio C Hamano wrote: > >> I think the addition of "config --path" support is a good idea, but the >> resulting code suffers from too many cut&paste cruft across the config* >> family of methods. >> >> How about doing a bit of refactoring, perhaps something like this, on top >> as a separate patch? > > This is a good idea, in my opinion. Thanks. >> I tried to be careful to still forcing the "one value only" for config_bool >> and config_int, but extra sets of eyeballs would be needed. > > We do have tests for that, have we? Perhaps, but I consider Perl "other peoples' problem" ;-) so... > BTW. why do you use hashref? Do you plan for the future to pass more > options that 'kind'? I don't, but other people might, and I didn't want to place undue burden on them. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html