On 27 September 2011 08:00, Roy Liu <carsomyr@xxxxxxxxx> wrote: > In git-submodule.sh, the "url" variable may contain a stale value from > the previous loop iteration, so clear it. > > --- git-submodule.sh.orig 2011-09-26 17:50:45.000000000 -0400 > +++ git-submodule.sh 2011-09-26 17:51:18.000000000 -0400 > @@ -370,6 +370,8 @@ > esac > git config submodule."$name".url "$url" || > die "Failed to register url for submodule path '$path'" > + else > + url="" > fi > > # Copy "update" setting when it is not set yet Perhaps a better commit description would be: git-submodule: clear the url variable when not set to avoid using stale values otherwise looks clean enough Andrew -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html