Re: [PATCH 3/6] branch: teach --edit-description option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:

> On Thu, Sep 22, 2011 at 03:09:19PM -0700, Junio C Hamano wrote:
>> +	if (launch_editor(git_path(edit_description), &buf, NULL)) {
>> +		strbuf_release(&buf);
>> +		return -1;
>> +	}
>> +	stripspace(&buf, 1);
>> +
>> +	strbuf_addf(&name, "branch.%s.description", branch_name);
>> +	status = git_config_set(name.buf, buf.buf);
>
> I suppose a Windows editor mave save the description with \r\n
> ending. Perhaps a patch like this to avoid messing up config file?

Doesn't stripspace() cleanse that already?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]