On 18/09/11 02:26, Pete Wyckoff wrote:
Here's a series that includes some changes to make git-p4 handle p4 filetypes better. This work was inspired by Chris Li, and includes some refactoring of the git-p4 tests that grew out of looking at Vitor's branch changes. It could use review for generic test beauty, as well as for the git-p4 filetype specifics in the code.
Modulo Junio's other comments, this looks sensible to me. I tried it on a sizeable tree and it didn't scramble anything (but that will only have tested the 'normal' filetypes).
Do we use $(some_command) rather than `some_command` now? A few other small comments to follow. Regards! Luke
contrib/fast-import/git-p4 | 91 +++++++++++++----- t/lib-git-p4.sh | 55 +++++++++++ t/t9800-git-p4.sh | 108 ++-------------------- t/t9801-git-p4-branch.sh | 221 ++++++++++++++++++++++++++++++++++++++++++++ t/t9802-git-p4-filetype.sh | 107 +++++++++++++++++++++ 5 files changed, 457 insertions(+), 125 deletions(-) Thanks, -- Pete
-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html